allow symfony 5, drop symfony 2 and php 5 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
force-pushed
the
update-dependencies
branch
from
c7f49dc to
823f2b2
Compare
Tobion
reviewed
Jan 28, 2020
| @@ -1,28 +1,37 @@ | |||
| language: php | |||
|
|
|||
| php: | |||
| - 5.6 | |||
| - 7.0 | |||
There was a problem hiding this comment.
7.0 (and 7.1) are not supported by php anymore
There was a problem hiding this comment.
yeah, but some people are stuck on outdated infrastructure. as long as its not creating problems, i would prefer to allow older versions.
|
Why is there a composer.lock file in a library? Shouldn't that be excluded? |
|
afaik @ChristianRiesen wanted that in the commit because there is a system to build a .phar from this code. with the .lock file, we avoid people ending up with a .phar that uses versions of the dependencies that have not been tested. (then again, there are so few tests that i don't know if its worth it) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.