-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature absgraph #24
Open
scrouthtv
wants to merge
20
commits into
rolinh:master
Choose a base branch
from
scrouthtv:feature-absgraph
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature absgraph #24
Commits on Dec 4, 2020
-
This first commit showcases some basic functionality. It currently only works in text mode and with color disabled. For this to work: - I added an agflag (*a*bsolute *g*raph) which is for now always set to 1 (enabled) - I changed the signature of the print_bar method and their implementations to consume three doubles: the used & total space on this volume as well as the total space on the greatest volume - I added an maxfssize variable alongside the max variable that stores the greatest volume's total space which is calculated whenever the latter is updated (see util.c) Every other impl other than the one in text is simply a stub for now.
Configuration menu - View commit details
-
Copy full SHA for 3f42cff - Browse repository at this point
Copy the full SHA 3f42cffView commit details -
Configuration menu - View commit details
-
Copy full SHA for bd3d617 - Browse repository at this point
Copy the full SHA bd3d617View commit details -
added an option to toggle the absolute graph view
I decided to go with -A, it is off by default (default behaviour is the same as before) I also added documentation in the english man page and help text, translated versions still need to add documentation for this as I speak neither french nor dutch :)
Configuration menu - View commit details
-
Copy full SHA for 5d60326 - Browse repository at this point
Copy the full SHA 5d60326View commit details
Commits on Dec 5, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 5363a6d - Browse repository at this point
Copy the full SHA 5363a6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a8986d - Browse repository at this point
Copy the full SHA 8a8986dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c63eaa - Browse repository at this point
Copy the full SHA 0c63eaaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fefe15 - Browse repository at this point
Copy the full SHA 0fefe15View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1f5f18 - Browse repository at this point
Copy the full SHA b1f5f18View commit details -
Configuration menu - View commit details
-
Copy full SHA for 304a99c - Browse repository at this point
Copy the full SHA 304a99cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 79ca9f3 - Browse repository at this point
Copy the full SHA 79ca9f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for a1ef877 - Browse repository at this point
Copy the full SHA a1ef877View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1826f76 - Browse repository at this point
Copy the full SHA 1826f76View commit details -
in absolute graph mode, it is wider than the other bars, so I needed support for flexible graph / bar width. before this commit, the color steps in the absolute summary graph would be on the same level as the ones above but not at the correct percentages, think something like this: sda1 ggggggyyyyrr-- sda2 ggggggy------- sda3 ggggggyy------ sum: ggggggyyyyrrrrrrrrrrrrrrrrr--------------- but it should look like this: ggggggggggggggggggyyyyyyyrr--------------- This issue is fixed in this commit.
Configuration menu - View commit details
-
Copy full SHA for 9e497ac - Browse repository at this point
Copy the full SHA 9e497acView commit details -
Configuration menu - View commit details
-
Copy full SHA for d17a5df - Browse repository at this point
Copy the full SHA d17a5dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 18ff796 - Browse repository at this point
Copy the full SHA 18ff796View commit details
Commits on Feb 3, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 82f6e82 - Browse repository at this point
Copy the full SHA 82f6e82View commit details
Commits on Feb 4, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 14761fe - Browse repository at this point
Copy the full SHA 14761feView commit details -
Configuration menu - View commit details
-
Copy full SHA for c4e0ee1 - Browse repository at this point
Copy the full SHA c4e0ee1View commit details
Commits on Mar 6, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 9729288 - Browse repository at this point
Copy the full SHA 9729288View commit details -
Fixed a bug where the details of the total bar would be off.
If dfc decides at runtime to only display short bars instead of wide bars, because the tty is too narrow, the `max.bar` still indicates `GRAPHBAR_WIDE` but it should be `GRAPHBAR_SHORT`. So for calculating the detail fields offset I am now using the ternary thing instead of `max.bar`. This requires another look into it because currently, the titlebar is off if we are using the `-w` option and the tty is too narrow.
Configuration menu - View commit details
-
Copy full SHA for 5da773a - Browse repository at this point
Copy the full SHA 5da773aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.