feat: print async_handler class to the log "Ready for review" #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I got this when I run the RSpec command locally
and spec for Rollbar JS failed too I'm not sure is it related to this PR |
saiqulhaq
commented
Jan 30, 2022
| it "shows 'Rollbar::Delay::SuckerPunch' on the log" do | ||
| Rollbar.configure do |config| | ||
| config.use_sucker_punch | ||
| config.transmit = false |
There was a problem hiding this comment.
I put transmit = false to skip Scheduled log
is it ok?
saiqulhaq
commented
Jan 30, 2022
| @@ -1863,6 +1893,16 @@ def backtrace | |||
| expect(thread.priority).to eq(custom_priority) | |||
| thread.join | |||
| end | |||
|
|
|||
| it "shows 'Rollbar::Delay::Thread' on the log" do | |||
There was a problem hiding this comment.
I found that ActiveJob test does not exist on rollbar_spec
but it shouldn't be a problem I think
saiqulhaq
commented
Jan 30, 2022
| ) | ||
| info_message = "[Rollbar] Details: #{uuid_url} (only available if report was successful)" | ||
| if configuration.async_handler | ||
| async_handler = configuration.async_handler.class == Class ? configuration.async_handler : configuration.async_handler.class |
There was a problem hiding this comment.
if async_handler is a Proc, then it will print Proc
|
@saiqulhaq Looks good. When #1082 merges, you should be able to rebase to this PR and fix the CI issues. I didn't see anything like the Rollbar.js issue in your comment, but did fix the dependency that caused CI to fail on this PR. |
|
ok will do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Related to the issue #1075.
Example:
Type of change
Development
Code review