[fix][sdk-372] Fix CI - Old Android SDK removed from Ubuntu 20.04 image runner #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ed0bdf1.
christianbuon
changed the title
christianbuon
changed the title
.github/workflows/ci.yml
Outdated
| - name: Setup Android SDK | ||
| uses: android-actions/setup-android@v3 | ||
| with: | ||
| cmdline-tools-version: 9477386 |
There was a problem hiding this comment.
The runner image ships with this version. Do you think we can avoid adding a 3rd party tool for it?
There was a problem hiding this comment.
yes, but they upgraded the build tools and platform version from 27 to 31. Ok, I'm going to download it manually
There was a problem hiding this comment.
Here is an example on how to install the old platform version with the existing SDK manager. You don't need to manually download it, or use 3rd party tools. If you don't install it, the Android Gradle Plugin figures out which version you need based on the project config and downloads it in the background.
|
Fixed in #317 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Old android SDK versions where removed from the runners in this PR, more info here.
To fix CI I'm adding the command line tools version 9.0 with this action, and setting the SDK manager to use Java 8 because it is incompatible with Java 11, as it was previously here
Type of change
Related issues
Checklists
Development
Code review