Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Bundle duplicated replace function #1128

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

fujiyamaorange
Copy link
Contributor

@fujiyamaorange fujiyamaorange commented Dec 21, 2023

Description of the change

Bundle duplicated replace function.

Type of change

  • Maintenance

Related issues

I've not create any issues because I met this duplications while I was reading codes.

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@fujiyamaorange fujiyamaorange marked this pull request as ready for review December 21, 2023 01:36
@fujiyamaorange fujiyamaorange changed the title [Refactor] Bundle duplicated function [Refactor] Bundle duplicated replace function Dec 21, 2023
Copy link
Contributor

@matux matux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, regarding comment:

If either target needs to change it, it can just be split back out again. And as @mudetroit said, there's very little active development in that code path anyway. - @waltjones

Thank you, @fujiyamaorange!

@matux matux merged commit 71b5e3a into rollbar:master Mar 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants