Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove is_js library from package-lock.json #1131

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

ddmilgram
Copy link
Contributor

@ddmilgram ddmilgram commented Feb 23, 2024

Description of the change

Remove is_js library, for security reasons

Type of change

  • Maintenance

Related issues

Shortcut stories and GitHub issues (delete irrelevant)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

Copy link

This pull request has been linked to Shortcut Story #131887: [rollbar.js] Remove usage of is_js from Rollbar.js SDK.

@ddmilgram ddmilgram merged commit 289f0ee into master Mar 1, 2024
4 checks passed
@matux matux deleted the dmilgram/sc-131887-remove-is-js branch March 3, 2024 00:22
mudetroit pushed a commit that referenced this pull request Mar 14, 2024
Remove is_js library from package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants