fix(pluginutils): improve regex performance (#1753)

perf(pluginutils): improve regex performance
rollup · Sep 22, 2024 · 184d81a · 184d81a
1 parent 369a768
commit 184d81a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/pluginutils/src/attachScopes.ts b/packages/pluginutils/src/attachScopes.ts
@@ -66,7 +66,7 @@ const attachScopes: AttachScopes = function attachScopes(ast, propertyName = 'sc
       const node = n as estree.Node;
       // function foo () {...}
       // class Foo {...}
-      if (/(Function|Class)Declaration/.test(node.type)) {
+      if (/(?:Function|Class)Declaration/.test(node.type)) {
         scope.addDeclaration(node, false, false);
       }
 
@@ -98,7 +98,7 @@ const attachScopes: AttachScopes = function attachScopes(ast, propertyName = 'sc
       }
 
       // create new for scope
-      if (/For(In|Of)?Statement/.test(node.type)) {
+      if (/For(?:In|Of)?Statement/.test(node.type)) {
         newScope = new Scope({
           parent: scope,
           block: true

diff --git a/packages/pluginutils/src/dataToEsm.ts b/packages/pluginutils/src/dataToEsm.ts
@@ -91,7 +91,7 @@ const dataToEsm: DataToEsm = function dataToEsm(data, options = {}) {
 
   let maxUnderbarPrefixLength = 0;
   for (const key of Object.keys(data)) {
-    const underbarPrefixLength = key.match(/^(_+)/)?.[0].length ?? 0;
+    const underbarPrefixLength = /^(_+)/.exec(key)?.[0].length ?? 0;
     if (underbarPrefixLength > maxUnderbarPrefixLength) {
       maxUnderbarPrefixLength = underbarPrefixLength;
     }