refactor: replace test with includes

rollup · Oct 15, 2024 · d6530b9 · d6530b9
1 parent 4a2358a
commit d6530b9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/node-resolve/src/index.js b/packages/node-resolve/src/index.js
@@ -292,15 +292,15 @@ export function nodeResolve(opts = {}) {
           return importee;
         }
         // ignore IDs with null character, these belong to other plugins
-        if (/\0/.test(importee)) return null;
+        if (importee.includes('\0')) return null;
 
         const { custom = {} } = resolveOptions;
         const { 'node-resolve': { resolved: alreadyResolved } = {} } = custom;
         if (alreadyResolved) {
           return alreadyResolved;
         }
 
-        if (/\0/.test(importer)) {
+        if (importer.includes('\0')) {
           importer = undefined;
         }
 

diff --git a/packages/pluginutils/src/attachScopes.ts b/packages/pluginutils/src/attachScopes.ts
@@ -82,7 +82,7 @@ const attachScopes: AttachScopes = function attachScopes(ast, propertyName = 'sc
       let newScope: AttachedScope | undefined;
 
       // create new function scope
-      if (/Function/.test(node.type)) {
+      if (node.type.includes('Function')) {
         const func = node as estree.Function;
         newScope = new Scope({
           parent: scope,
@@ -106,7 +106,7 @@ const attachScopes: AttachScopes = function attachScopes(ast, propertyName = 'sc
       }
 
       // create new block scope
-      if (node.type === 'BlockStatement' && !/Function/.test(parent.type)) {
+      if (node.type === 'BlockStatement' && !parent.type.includes('Function')) {
         newScope = new Scope({
           parent: scope,
           block: true