Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): add tips for issue numbers in pr template #1516

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

TrickyPi
Copy link
Member

Rollup Plugin Name: {name}

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

I found some PRs that didn't use resolves or other fields to link the issues it will fix, so I added some tips from https://github.com/rollup/rollup/blob/master/.github/PULL_REQUEST_TEMPLATE.md

@TrickyPi TrickyPi requested a review from shellscape as a code owner June 12, 2023 09:17
@shellscape
Copy link
Collaborator

Thanks for the suggestion. I'm not sure we need such a large block dedicated to that, since it historically hasn't been a problem with housekeeping.

@TrickyPi
Copy link
Member Author

Sorry for the late reply. I think the "resolves" field is a huge help for contributors or maintainers. In the issues panel, we can easily know which issues have which PRs will close it, there is similar help in the PRs panel. BTW, some issues have been fixed but not closed yet, e.g. #1465, the "resolves" field will also reduce the occurrence of this situation.

@shellscape shellscape changed the title chore: add tips for issue numbers in pr template chore(repo): add tips for issue numbers in pr template Sep 13, 2023
@shellscape shellscape merged commit 68bd0df into rollup:master Sep 13, 2023
1 of 5 checks passed
@TrickyPi TrickyPi deleted the chore/pr branch September 16, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants