fix(node-resolve): prevent infinite findPackageJson loop

[dasdeo]

This is fixed by checking if the root directory (/) was already looped over.

Rollup Plugin Name: node-resolve

This PR contains:

• bugfix
• feature
• refactor
• documentation
• other

Are tests included?

• yes (bugfixes and features will not be merged without tests)
• no

Breaking Changes?

• yes (breaking changes will not be merged unless absolutely necessary)
• no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

resolves #1647

Description

[shellscape]

Thanks for the PR! We'll need a test added for this before we can merge though. The test should probably recreate the situation as noted in the linked issue, and it should fail if the fix isn't present.

[dasdeo]

I would write a unit test if I knew how since this is using the file system.

Any resources on how you deal with that in this project?

[shellscape]

yeah most of our tests use file based fixtures for executing a build. I'd use those as a reference.

[dasdeo]

I just had this thought, I could be using my repository that I used to show the bug as a template for the fixture.

I might be adding the test case for this bug in the next couple of days.

Just to be sure, tests are located at https://github.com/rollup/plugins/tree/master/packages/node-resolve/test/fixtures right?

[shellscape]

Just to be sure, tests are located at https://github.com/rollup/plugins/tree/master/packages/node-resolve/test/fixtures right?

The fixtures are there. The tests are a directory level up

[shellscape]

@dasdeo will you have the chance to write a test for this change? I'd like to merge it, but we need to protect against future regressions.

[shellscape]

Closing as abandoned.