chore(repo): use shell-emulator for better cross-platform compatibility #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbayley
requested review from
tada5hi,
tjenkinson,
Andarist and
shellscape
as code owners
danielbayley
force-pushed
the
shell-emulator
branch
from
142b54f to
2f47dfd
Compare
tada5hi
changed the title
tada5hi
approved these changes
Jul 3, 2024
|
failing wasm test should be unrelated to pr?! |
shellscape
changed the title
shellscape
approved these changes
Sep 22, 2024
There was a problem hiding this comment.
@danielbayley I'm good to merge this once the conflicts are resolved. To resolve the pnpm-lock conflict, run pnpm i in the repo root and pnpm will take care of it for us.
danielbayley
force-pushed
the
shell-emulator
branch
from
2f47dfd to
7d4dee5
Compare
|
@shellscape Should be resolved now… |
|
Closing as abandoned. Please feel free to reopen if you get back around to it. |
I resolved the issue, as requested @shellscape 🤷🏻♂️ My other PR (#1744) is on hold only because/if #1782 is set to supercede it… But as already mentioned, this one should be good to go! @shellscape |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
*This PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
Description
I started work on a separate PR, but quickly ran into errors with the
preparescriptsapparently not being cross-platform (ifcommand not found—I am on macOS). Since this is apnpmmonorepo, and thescriptsare very simple, why not make use of theshell-emulator.npmrcconfig option (which uses yarnpkg-shell)? This also means the dependency ondel-cliis no longer necessary.