Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(replace): The preventAssignment option is treated as a value to replace #1768

Merged
merged 8 commits into from
Sep 23, 2024

Conversation

Finesse
Copy link
Contributor

@Finesse Finesse commented Sep 20, 2024

Rollup Plugin Name: replace

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

When the values option is not and the preventAssignment option is set, the plugin replaces preventAssignment in the transformed code with the according option value. This PR fixes this bug.

@Finesse Finesse requested a review from shellscape as a code owner September 20, 2024 10:56
@shellscape
Copy link
Collaborator

@Finesse this is approved, but we need to get the snapshots updated first. please run pnpm --filter @rollup/plugin-replace test --u to update the snapshots, and merge the result.

@Finesse Finesse force-pushed the fix/prevent-assignment branch from c66bb2b to ca4ad76 Compare September 23, 2024 05:58
@Finesse
Copy link
Contributor Author

Finesse commented Sep 23, 2024

@shellscape The command you provided doesn't work. This command works: pnpm --filter @rollup/plugin-replace test -- -u.

I've run this command and pushed the changes. Sorry for not checking it on my local machine. The misc and sourcemaps snapshots also changed after running the command, but they change the same way when I run the command on master, so I've decided not to push them.

@shellscape shellscape merged commit 0a31668 into rollup:master Sep 23, 2024
5 checks passed
@Finesse Finesse deleted the fix/prevent-assignment branch September 23, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants