Add a suffix option #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, this plugin would add `.rtl` to the filenames In various use cases, it might be useful to use other suffixes, like `-rtl` for example. This changes adds a suffix option, to replace the default `.rtl` if set (and if the `filename` option isn't set)
yoavf
added a commit
to yoavf/gutenberg
that referenced
this pull request
Dec 7, 2017
This currently loads the version from https://github.com/yoavf/webpack-rtl-plugin/tree/develop This include a simple (but required) change, that's been requested upstream as a PR: romainberger/webpack-rtl-plugin#15
3 tasks
youknowriad
pushed a commit
to WordPress/gutenberg
that referenced
this pull request
Dec 7, 2017
* fix add new post button for RTL (minor) * Remove manual RTL css We're going to autogenerate RTL css files, so this won't be needed * Add temp version of webpack-rtl-plugin This currently loads the version from https://github.com/yoavf/webpack-rtl-plugin/tree/develop This include a simple (but required) change, that's been requested upstream as a PR: romainberger/webpack-rtl-plugin#15 * use webback-rtl-plugin to create -rtl css files * Load -rtl css files for all Gutenberg css files This is done by adding style data - WP will automatically load the -rtl css files instead of the regular files in RTL mode. * whitespace, add inline comment to build file * indenting fix * Improve RTL styles on the desktop breakpoint. * TintMCE: Fix TinyMCE initialization for RTL languages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, this plugin would add
.rtlto the original filenames.In various use cases, it might be useful to use other suffixes, like
-rtlfor example.This change adds a suffix option, to replace the default
.rtlif set (and if thefilenameoption isn't set)