-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
module.exports is not matched #10
Comments
This could be an extension of the
|
nice! I think this could work. Any plans to update the master branch? |
I don't think I'll be able to do it in the short term. Could you give it a try on your side? |
So I added the following to the bottom of my
... and can confirm it works well! This was the one thing missing for me to have full tag support, as far as I can tell, for JS in my vim. Thanks! I'll send a PR to add to the file in case that's helpful. |
This fixes romainl#10.
This fixes romainl#10.
Thanks for this - tossing in another possible scenario for the exports = module.exports = /*<function or object>*/; LMK if there's anything I can do |
The following function is not matched:
I've done a rule to match that case as a function, but don't know if you didn't want to support on purpose since this is also the case for
export default function name1(…) { … }
as you pointed out on issue #7.Wouldn't make sense to create an
default export
tag type and put them together on that new tag type? What do you think?(We could try to create a rule only for default named exports with body definition once the ones that doesn't have definition would be already taken by another rules)
The text was updated successfully, but these errors were encountered: