Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for module.exports functions #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

filmaj
Copy link

@filmaj filmaj commented Apr 21, 2019

This fixes #10, fyi @romainl @rkulla

@romainl
Copy link
Owner

romainl commented Apr 22, 2019

Thank you @filmaj.

Could you add a test snippet to index.js and update the README.md to make this PR complete?

@filmaj
Copy link
Author

filmaj commented Apr 22, 2019

Sure thing, I think I added what was necessary. I'm not 100% sure if the tags file output is correct - I see two entries related to the test function name mod_exports_func that I added:

➜ make && grep mod_exp tags
[ 2019-04-22 - 08:44:39 ] 'tags' file updated.
exports	index.js	/^module.exports = function mod_exports_func() {$/;"	M
mod_exports_func	index.js	/^module.exports = function mod_exports_func() {$/;"	F

Hmm, I guess it is also picked up as a method name - do you think that is OK?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

module.exports is not matched
2 participants