-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Add Ubuntu 24.10 Build #16667
[ci] Add Ubuntu 24.10 Build #16667
Conversation
Test Results 17 files 17 suites 3d 9h 36m 16s ⏱️ For more details on these failures, see this check. Results for commit 5136747. ♻️ This comment has been updated with latest results. |
@@ -95,8 +95,8 @@ ExternalProject_Add( | |||
-DLLVM_DIR=${LLVM_BINARY_DIR} | |||
-DCLANG_INCLUDE_DIRS=${CLANG_INCLUDE_DIRS} | |||
${_clad_extra_cmake_args} | |||
BUILD_COMMAND ${CMAKE_COMMAND} --build . ${EXTRA_BUILD_ARGS} | |||
INSTALL_COMMAND ${CMAKE_COMMAND} --build . ${EXTRA_BUILD_ARGS} --target install | |||
BUILD_COMMAND ${CMAKE_COMMAND} --build . ${EXTRA_BUILD_ARGS} -j 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a comment why '-j 1' is needed (is it a temporary workaround until something is fixed in clad or is it a limitation of the platform and/or MV configuration?).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. I wanted to test this at scale before documenting further. @vgvassilev any thought about why this is now necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure I have seen the actual build failure to be able to comment. Can you give me a link to the failure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just remove the "-j1"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not have access to ubu24 system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but you have the line to reproduce the failure locally with the container, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just can't reproduce and debug these failues on a clean ubuntu 24.10 install... I don't think we can make progress on this in the next 10 day :( Would it make sense maybe to add it to the CI with |
This PR is fixing the ubuntu 24.10 failures #16837 . We can introduce the new CI build directly with that. |
Build clad with one core only.