-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for NVIDIA nvc++ compiler #17000
base: master
Are you sure you want to change the base?
Conversation
Test Results 18 files 18 suites 4d 15h 23m 21s ⏱️ Results for commit f41386a. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tried to run the test suite for ROOT with this pull request and nvcc? My worry is that we have to execute cuda code in the interpreter through clang and some changes in the interpreter's cmake files seem to go towards getting the nvcc runtime somehow in cling.
@@ -9,7 +9,14 @@ | |||
#--------------------------------------------------------------------------------------------------- | |||
|
|||
if(NOT CMAKE_CXX_COMPILER_ID MATCHES "(Apple|)Clang|GNU|Intel|MSVC") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need a check here for NVHPC
too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I understand this condition filters out supported compilers. As NVHPC
is only partially supported, it must enter this condition - note the NOT
in front.
@cgleggett so this means the most recent |
what is the recommended way to test a build? I was able to do I/O and read/write root files, but that obviously doesn't cover everything. |
If you would like to run the full test suite, you can configure with:
and run You can also start without the |
This Pull request:
Adds support for NVIDIA's nvc++ compiler
Changes or fixes:
This allows clean compilation on ARM (NVIDIA Grace) CPUs.