[core] Move arguments with deleted copy ctor in TClingCallFunc #17030
+292
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hahnjo
requested review from
bellenot,
jblomer,
dpiparo and
pcanal
as code owners
vgvassilev
reviewed
Nov 25, 2024
Test Results 18 files 18 suites 4d 3h 8m 23s ⏱️ Results for commit 5ba7196. ♻️ This comment has been updated with latest results. |
hahnjo
force-pushed
the
callfunc-move
branch
2 times, most recently
from
6adfb63
to
c123eea
Compare
hahnjo
changed the title
vgvassilev
reviewed
Nov 26, 2024
vgvassilev
reviewed
Nov 26, 2024
vgvassilev
reviewed
Nov 26, 2024
If a type is passed by value but cannot be copy-constructed, instead move the argument. This is important to make std::unique_ptr interfaces work from Python code. Note that there are corner cases where checking for a deleted copy constructor is not sufficient; for example the STL always declares a copy constructor for std::vector<std::unique_ptr<T>> which fails to instantiate if T is only moveable. Closes root-project#14425 Co-authored-by: Vincenzo Eduardo Padulano <[email protected]>
Co-authored-by: Vassil Vassilev <[email protected]>
hahnjo
force-pushed
the
callfunc-move
branch
from
c123eea
to
5ba7196
Compare
dpiparo
approved these changes
Nov 26, 2024
pcanal
reviewed
Nov 26, 2024
|
|
||
| for (auto *Ctor : RD->ctors()) { | ||
| if (Ctor->isCopyConstructor()) { | ||
| return Ctor->isDeleted(); |
There was a problem hiding this comment.
Should we also return true is the constructor is private or protected? (Since it has essentially the same effect)
There was a problem hiding this comment.
I would argue that no because it may be unexpected for the user that TClingCallFunc moves its objects when they "forget" to make their copy constructor public...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a type is passed by value but cannot be copy-constructed, instead move the argument. This is important to make
std::unique_ptrinterfaces work from Python code. Note that there are corner cases where checking for a deleted copy constructor is not sufficient; for example the STL always declares a copy constructor forstd::vector<std::unique_ptr<T>>which fails to instantiate if
Tis only moveable.Closes #14425, alternative to #14426