Adapt to CMake policy CMP0146, FindCUDA.cmake removed #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amadio
requested changes
Jan 30, 2024
There was a problem hiding this comment.
The idea of modernizing CUDA support is good, but as is I think it will not work. At least the call to find_package(VecCore COMPONENTS CUDA) needs to work when CUDA component is requested, by maybe calling enable_language(CUDA) or checking that it's enabled, and adding the proper includes/compile flags to the VecCore interface library.
|
@mrguilima I made some minor changes to your commit, and merged the commits into a single one. Sorry for taking long to process this, XRootD/EOS keep me quite busy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CMake module FindCUDA has been removed by CMP0146.
This commit removes the use of
find_package(CUDA 8.0 REQUIRED), while declaring CUDA as a top-level language in the project, if enabled by the user.