Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple logic from actual autoloader class filesystem location #5

Open
austinpray opened this issue Jun 9, 2019 · 0 comments
Open

Decouple logic from actual autoloader class filesystem location #5

austinpray opened this issue Jun 9, 2019 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Milestone
2.0.0

Comments

@austinpray
Copy link
Collaborator

It seems that a lot of the logic relies on the autoloader living in the mu-plugins dir. Since this is just a regular composer library we need to ensure that the relevant locations are passed in as params

bedrock-autoloader/src/Autoloader.php

Line 58 in 02e61a6

$this->relativePath = '/../' . basename(__DIR__);

roots/bedrock#299 (comment)
@austinpray austinpray added help wanted Extra attention is needed good first issue Good for newcomers labels Jun 9, 2019
@austinpray austinpray changed the title Decouple logic from actual autoloader class location Decouple logic from actual autoloader class filesystem location Jun 9, 2019
@vinkla vinkla mentioned this issue Jun 9, 2019
Closed
@austinpray austinpray added this to the 2.0.0 milestone May 16, 2020
@austinpray austinpray mentioned this issue May 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@austinpray