add 'merge_duplicated_col_names' fn to fix #348

DESCRIPTION

@@ -1,6 +1,6 @@
 Package: osmdata
 Title: Import 'OpenStreetMap' Data as Simple Features or Spatial Objects
-Version: 0.2.5.018
+Version: 0.2.5.019
 Authors@R: c(
     person("Mark", "Padgham", , "[email protected]", role = c("aut", "cre")),
     person("Bob", "Rudis", role = "aut"),

NEWS.md

@@ -11,6 +11,7 @@
 - Improved `get_bb(..., format_out = "sf_polygon")` to return full metadata
   along with geometries (#338 thanks to @RegularnaMatrica)
 - Mention key-only feature requests in README (#342 thanks to @joostschouppe)
+- Merge any columns in `osmdata_sf()` with mixed-case duplicated names (#348)
 
 
 0.2.5

R/get-osmdata-sf.R

@@ -121,6 +121,8 @@ make_sf <- function (..., stringsAsFactors = FALSE) { # nolint
         )
     }
 
+    df <- merge_duplicated_col_names (df)
+
     object <- as.list (substitute (list (...))) [-1L]
     arg_nm <- sapply (object, function (x) deparse (x)) # nolint
     sfc_name <- make.names (arg_nm [sf_column])
@@ -138,6 +140,28 @@ make_sf <- function (..., stringsAsFactors = FALSE) { # nolint
     return (df)
 }
 
+#' Merge any `sf` `data.frame` columns which have mixed-case duplicated names
+#' (like "This" and "this"; #348).
+merge_duplicated_col_names <- function (df) {
+
+    nms_lower <- tolower (names (df))
+    dups <- which (duplicated (nms_lower))
+    if (length (dups) > 0L) {
+        dup_nms <- nms_lower [dups]
+        cols_to_rm <- NULL
+        for (nm in dup_nms) {
+            index <- which (nms_lower == nm)
+            df [, index [1]] <- apply (df [, index], 1, function (i) {
+                ifelse (all (is.na (i)), i [1], i [which (!is.na (i)) [1]])
+            })
+            cols_to_rm <- c (cols_to_rm, index [2])
+        }
+        df <- df [, -(cols_to_rm)]
+    }
+
+    return (df)
+}
+
 
 sf_types <- c ("points", "lines", "polygons", "multilines", "multipolygons")
 

codemeta.json

@@ -11,7 +11,7 @@
   "codeRepository": "https://github.com/ropensci/osmdata/",
   "issueTracker": "https://github.com/ropensci/osmdata/issues",
   "license": "https://spdx.org/licenses/GPL-3.0",
-  "version": "0.2.5.018",
+  "version": "0.2.5.019",
   "programmingLanguage": {
     "@type": "ComputerLanguage",
     "name": "R",