Add suport for Excel style hyperlinks #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcnamara
commented
Apr 21, 2021
R/excel_types.R
Outdated
| if(length(name)){ | ||
| hyperlink <- paste(hyperlink, dubquote(name), sep = ",") | ||
| } | ||
| out <- xl_formula(sprintf("=HYPERLINK(%s)", hyperlink)) | ||
| out <- url |
There was a problem hiding this comment.
This really needs to return something like list(url, name).
jmcnamara
commented
Apr 21, 2021
src/write_xlsx.c
Outdated
| @@ -170,7 +165,7 @@ SEXP C_write_data_frame_list(SEXP df_list, SEXP file, SEXP col_names, SEXP forma | |||
| case COL_HYPERLINK:{ | |||
| SEXP val = STRING_ELT(col, i); | |||
| if(val != NA_STRING && Rf_length(val)) | |||
| assert_lxw(worksheet_write_formula(sheet, cursor, j, Rf_translateCharUTF8(val), hyperlink)); | |||
| assert_lxw(worksheet_write_url(sheet, cursor, j, Rf_translateCharUTF8(val), NULL)); | |||
There was a problem hiding this comment.
This should be worksheet_write_url_opt() to also set the string name for the hyperlink. But that is an easy change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace existing hyperlink support via formulas with native Excel url types and the default hyperlink style.
This is work in progress and not complete but I wanted to set up a conversation.
The advantage of using the native style urls is that they look like Excel links and they supports a hyperlink style (not format) that changes colour once the link is clicked, as shown in the image:
The PR is an initial pass at this but I don't know what would be the best way to pass back the 'url' and optional 'name' as a pair in the xl_hyperlink object. So if you are interested in adopting this feature I would appreciate your guidance on that. My initial thoughts were to have them in a list but I don't know if that is the best way.
Relates to issue #5.