Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workflows for PRs (backport #135) #147

Merged
merged 2 commits into from
Aug 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 0 additions & 27 deletions .github/actions/install-dependencies/action.yml

This file was deleted.

18 changes: 16 additions & 2 deletions .github/workflows/reusable-sphinx-check-single-version.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,22 @@ jobs:
repository: ros-controls/control.ros.org
ref: master
fetch-depth: 0
- name: Install dependencies
uses: ros-controls/control.ros.org/.github/actions/install-dependencies@master
- uses: actions/setup-python@v4
with:
python-version: '3.10'
cache: 'pip'
- name: Install Python dependencies
run: |
python -m pip install --upgrade pip
pip install --upgrade --requirement requirements.txt
shell: bash
- name: Install generate_parameter_library
run: |
cd
git clone https://github.com/PickNikRobotics/generate_parameter_library.git
cd generate_parameter_library/generate_parameter_library_py/
python -m pip install .
shell: bash
- name: Build single version with optional PRs' numbers considering warnings as errors
env:
ROS2_CONTROL_PR: ${{ inputs.ROS2_CONTROL_PR }}
Expand Down
20 changes: 17 additions & 3 deletions .github/workflows/sphinx-check-links.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ on:
workflow_dispatch:
push:
branches:
- master
- iron
schedule:
# Run every morning to ensure component documentation is up to date on deployment
- cron: '23 5 * * *'
Expand All @@ -16,8 +16,22 @@ jobs:
- uses: actions/checkout@v3
with:
fetch-depth: 0
- name: Install dependencies
uses: ./.github/actions/install-dependencies
- uses: actions/setup-python@v4
with:
python-version: '3.10'
cache: 'pip'
- name: Install Python dependencies
run: |
python -m pip install --upgrade pip
pip install --upgrade --requirement requirements.txt
shell: bash
- name: Install generate_parameter_library
run: |
cd
git clone https://github.com/PickNikRobotics/generate_parameter_library.git
cd generate_parameter_library/generate_parameter_library_py/
python -m pip install .
shell: bash
- name: Install doxygen and graphviz
run: sudo apt-get install -y doxygen graphviz
- name: Build page with API and run linkchecker
Expand Down
33 changes: 33 additions & 0 deletions .github/workflows/sphinx-check-warnings-pr.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
name: "Check Page for Warnings (PR)"
on:
workflow_dispatch:
pull_request:

jobs:
build-singleversion-halt-on-warnings:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
with:
fetch-depth: 0
- uses: actions/setup-python@v4
with:
python-version: '3.10'
cache: 'pip'
- name: Install Python dependencies
run: |
python -m pip install --upgrade pip
pip install --upgrade --requirement requirements.txt
shell: bash
- name: Install generate_parameter_library
run: |
cd
git clone https://github.com/PickNikRobotics/generate_parameter_library.git
cd generate_parameter_library/generate_parameter_library_py/
python -m pip install .
shell: bash
- name: Build single version considering warnings as errors
run: |
git config --local user.email "[email protected]"
git config --local user.name "GitHub Action"
make html-all-subrepos-with-errors
27 changes: 20 additions & 7 deletions .github/workflows/sphinx-check-warnings.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,23 +3,36 @@ on:
workflow_dispatch:
push:
branches:
- master
- iron
schedule:
# Run every morning to ensure component documentation is up to date on deployment
- cron: '23 5 * * *'
pull_request:

jobs:
build-halt-on-errors:
build-halt-on-warnings:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
with:
fetch-depth: 0
- name: Install dependencies
uses: ./.github/actions/install-dependencies
- name: Build multiversion considering warnings as errors
- uses: actions/setup-python@v4
with:
python-version: '3.10'
cache: 'pip'
- name: Install Python dependencies
run: |
python -m pip install --upgrade pip
pip install --upgrade --requirement requirements.txt
shell: bash
- name: Install generate_parameter_library
run: |
cd
git clone https://github.com/PickNikRobotics/generate_parameter_library.git
cd generate_parameter_library/generate_parameter_library_py/
python -m pip install .
shell: bash
- name: Build single version considering warnings as errors
run: |
git config --local user.email "[email protected]"
git config --local user.name "GitHub Action"
make multiversion-with-errors
make html-all-subrepos-with-errors
40 changes: 0 additions & 40 deletions .github/workflows/sphinx-make-page.yml

This file was deleted.

2 changes: 1 addition & 1 deletion make_help_scripts/add_tmp_commits
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ add_sub_repositories_and_commit () {
sed -i "s/doc\/ros2_control/\#doc\/ros2_control/g" .gitignore
sed -i "s/doc\/gz_ros2_control/\#doc\/gz_ros2_control/g" .gitignore
sed -i "s/doc\/gazebo_ros2_control/\#doc\/gazebo_ros2_control/g" .gitignore
# clone all subrepositorie and add as tmp commit to branch of multi version
# clone all subrepositories and add as tmp commit to branch of multi version
echo "Clone repositories for $branch and checkout ${branch_version[$branch]}"
for repo_name in "${!subrepo_url[@]}";
do echo "Create doc/$repo_name";
Expand Down
Loading