Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load the URDF to the resource_manager before parsing it to CM #222

Conversation

saikishor
Copy link
Member

@saikishor saikishor requested a review from ahcorde as a code owner January 22, 2024 09:20
@saikishor
Copy link
Member Author

@ahcorde I believe this will be needed as well. Sorry for the late notice

@saikishor saikishor force-pushed the fix_crash_for_missing_urdf_in_resource_manager branch from 62cc7bd to f71b223 Compare January 22, 2024 09:42
@saikishor saikishor force-pushed the fix_crash_for_missing_urdf_in_resource_manager branch from f71b223 to 8612b02 Compare January 22, 2024 09:59
@saikishor
Copy link
Member Author

The binaries seem to be old for this build to work here

@ahcorde
Copy link
Collaborator

ahcorde commented Jan 23, 2024

requires #223

@ahcorde ahcorde merged commit 5a94805 into ros-controls:master Jan 24, 2024
5 of 7 checks passed
@ahcorde
Copy link
Collaborator

ahcorde commented Jan 24, 2024

https://github.com/Mergifyio backport humble iron

Copy link
Contributor

mergify bot commented Jan 24, 2024

backport humble iron

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 24, 2024
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
(cherry picked from commit 5a94805)
mergify bot pushed a commit that referenced this pull request Jan 24, 2024
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
(cherry picked from commit 5a94805)
ahcorde pushed a commit that referenced this pull request Jan 24, 2024
…226)

Co-authored-by: Alejandro Hernández Cordero <[email protected]>
(cherry picked from commit 5a94805)

Co-authored-by: Sai Kishor Kothakota <[email protected]>
ahcorde pushed a commit that referenced this pull request Jan 24, 2024
…225)

Co-authored-by: Alejandro Hernández Cordero <[email protected]>
(cherry picked from commit 5a94805)

Co-authored-by: Sai Kishor Kothakota <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants