Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crashing due to an invalid parameter in the initial value #233

Merged

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Feb 13, 2024

Related with this PR in gazebo_ros2_pkgs ros-controls/gazebo_ros2_control#271

@ahcorde ahcorde self-assigned this Feb 13, 2024
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahcorde ahcorde merged commit a3beadb into master Feb 13, 2024
8 checks passed
@ahcorde ahcorde deleted the ahcorde/rolling/fix_crashing_with_wrong_initial_value branch February 13, 2024 11:17
@ahcorde
Copy link
Collaborator Author

ahcorde commented Feb 13, 2024

https://github.com/Mergifyio backport humble iron

Copy link
Contributor

mergify bot commented Feb 13, 2024

backport humble iron

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 13, 2024
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
(cherry picked from commit a3beadb)

# Conflicts:
#	ign_ros2_control/src/ign_system.cpp
mergify bot pushed a commit that referenced this pull request Feb 13, 2024
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
(cherry picked from commit a3beadb)

# Conflicts:
#	gz_ros2_control/src/gz_system.cpp
ahcorde added a commit that referenced this pull request Feb 13, 2024
#233) (#234)

* Fix crashing due to an invalid parameter in the initial value (#233)

Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
(cherry picked from commit a3beadb)

# Conflicts:
#	ign_ros2_control/src/ign_system.cpp

* Fixed merge

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

---------

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
ahcorde added a commit that referenced this pull request Feb 13, 2024
#233) (#235)

* Fix crashing due to an invalid parameter in the initial value (#233)

Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
(cherry picked from commit a3beadb)

# Conflicts:
#	gz_ros2_control/src/gz_system.cpp

* Fixed merge

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

---------

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants