Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mecanum vehicle example #451

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

MarqRazz
Copy link
Contributor

@MarqRazz MarqRazz commented Dec 5, 2024

As the title says this adds a new example showing how to use the new MecanumDriveController in ros2_controllers 🏆.
mecanum_vehicle

The odometry of the vehicle is still a little off when rotating because I don't fully understand what sum_of_robot_center_projection_on_X_Y_axis parameter would equate to for this vehicle.

@MarqRazz
Copy link
Contributor Author

MarqRazz commented Dec 6, 2024

Looks like this might be blocked on the mecanum controller getting released.
gz_ros2_control_demos: Cannot locate rosdep definition for [mecanum_drive_controller]

@christophfroehlich
Copy link
Contributor

@bmagyar just released it ;)

@bmagyar
Copy link
Member

bmagyar commented Dec 7, 2024

I am Santa, reading your wishlists on github

ros/rosdistro#43821
ros/rosdistro#43822

Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment, otherwise lgtm when the ci is green. I just merged the PRs in ros_distro

@ahcorde
Copy link
Collaborator

ahcorde commented Dec 9, 2024

https://github.com/Mergifyio backport jazzy

Copy link
Contributor

mergify bot commented Dec 9, 2024

backport jazzy

🟠 Waiting for conditions to match

  • merged [📌 backport requirement]

@ahcorde
Copy link
Collaborator

ahcorde commented Dec 10, 2024

@Pratham-Pandey can you help us to setup sum_of_robot_center_projection_on_X_Y_axis ?

@Pratham-Pandey
Copy link

From what I understood, sum_of_robot_center_projection_on_X_Y_axis is the sum of distance between robot frame(usually at the center) and the wheels. For example if the robot have 4 wheels, we will consider distance to any one wheel(assuming each wheel is equidistant from the robot frame). The distance in x axis plus the distance in y axis.

@MarqRazz
Copy link
Contributor Author

Thanks for the explanation @Pratham-Pandey! For some reason I half'd the value to the wheels in the X and Y thinking I had that as the total wheel base. This is corrected now and reports odom that matches the pose of the vehicle in Gazebo.

@ahcorde ahcorde merged commit 18bdde1 into ros-controls:rolling Dec 11, 2024
1 check passed
@ahcorde
Copy link
Collaborator

ahcorde commented Dec 11, 2024

https://github.com/Mergifyio backport jazzy

Copy link
Contributor

mergify bot commented Dec 11, 2024

backport jazzy

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 11, 2024
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
(cherry picked from commit 18bdde1)
ahcorde pushed a commit that referenced this pull request Dec 11, 2024
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
(cherry picked from commit 18bdde1)

Co-authored-by: Marq Rasmussen <[email protected]>
@MarqRazz MarqRazz deleted the mecanum_drive_example branch December 11, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants