Bump version of pre-commit hooks (backport #1556) (#1557)

* Bump version of pre-commit hooks (#1556) * Bump version of pre-commit hooks * Fix codespell and satisfy linter --------- Co-authored-by: christophfroehlich <[email protected]> Co-authored-by: Christoph Froehlich <[email protected]> (cherry picked from commit 765241e) * Fix codespell --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Christoph Froehlich <[email protected]>
ros-controls · Jun 1, 2024 · c04a16f · c04a16f
1 parent c820eec
commit c04a16f
Show file tree

Hide file tree

Showing 7 changed files with 17 additions and 13 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -62,7 +62,7 @@ repos:
 
   # CPP hooks
   - repo: https://github.com/pre-commit/mirrors-clang-format
-    rev: v18.1.4
+    rev: v18.1.5
     hooks:
       - id: clang-format
         args: ['-fallback-style=none', '-i']
@@ -125,14 +125,14 @@ repos:
   # Spellcheck in comments and docs
   # skipping of *.svg files is not working...
   - repo: https://github.com/codespell-project/codespell
-    rev: v2.2.6
+    rev: v2.3.0
     hooks:
       - id: codespell
         args: ['--write-changes', '--uri-ignore-words-list=ist', '-L manuel']
         exclude: CHANGELOG\.rst|\.(svg|pyc|drawio)$
 
   - repo: https://github.com/python-jsonschema/check-jsonschema
-    rev: 0.28.2
+    rev: 0.28.4
     hooks:
       - id: check-github-workflows
         args: ["--verbose"]

diff --git a/controller_manager/src/controller_manager.cpp b/controller_manager/src/controller_manager.cpp
@@ -2495,7 +2495,7 @@ bool ControllerManager::controller_sorting(
     }
 
     // If the ctrl_a's state interface is the one exported by the ctrl_b then ctrl_b should be
-    // infront of ctrl_a
+    // in front of ctrl_a
     // TODO(saikishor): deal with the state interface chaining in the sorting algorithm
     auto state_it = std::find_if(
       state_itfs.begin(), state_itfs.end(),

diff --git a/controller_manager/test/test_spawner_unspawner.cpp b/controller_manager/test/test_spawner_unspawner.cpp
@@ -233,7 +233,8 @@ TEST_F(TestLoadController, unload_on_kill)
   // Launch spawner with unload on kill
   // timeout command will kill it after the specified time with signal SIGINT
   std::stringstream ss;
-  ss << "timeout --signal=INT 5 " << "ros2 run controller_manager spawner "
+  ss << "timeout --signal=INT 5 "
+     << "ros2 run controller_manager spawner "
      << "ctrl_3 -c test_controller_manager -t "
      << std::string(test_controller::TEST_CONTROLLER_CLASS_NAME) << " --unload-on-kill";
 

diff --git a/hardware_interface/include/hardware_interface/actuator_interface.hpp b/hardware_interface/include/hardware_interface/actuator_interface.hpp
@@ -131,7 +131,7 @@ class ActuatorInterface : public rclcpp_lifecycle::node_interfaces::LifecycleNod
    * \note All starting and stopping interface keys are passed to all components, so the function
    * should return return_type::OK by default when given interface keys not relevant for this
    * component. \param[in] start_interfaces vector of string identifiers for the command interfaces
-   * starting. \param[in] stop_interfaces vector of string identifiers for the command interfacs
+   * starting. \param[in] stop_interfaces vector of string identifiers for the command interfaces
    * stopping. \return return_type::OK if the new command interface combination can be prepared, or
    * if the interface key is not relevant to this system. Returns return_type::ERROR otherwise.
    */
@@ -150,7 +150,7 @@ class ActuatorInterface : public rclcpp_lifecycle::node_interfaces::LifecycleNod
    * \note All starting and stopping interface keys are passed to all components, so the function
    * should return return_type::OK by default when given interface keys not relevant for this
    * component. \param[in] start_interfaces vector of string identifiers for the command interfaces
-   * starting. \param[in] stop_interfaces vector of string identifiers for the command interfacs
+   * starting. \param[in] stop_interfaces vector of string identifiers for the command interfaces
    * stopping. \return return_type::OK if the new command interface combination can be switched to,
    * or if the interface key is not relevant to this system. Returns return_type::ERROR otherwise.
    */

diff --git a/hardware_interface/include/hardware_interface/resource_manager.hpp b/hardware_interface/include/hardware_interface/resource_manager.hpp
@@ -346,7 +346,7 @@ class HARDWARE_INTERFACE_PUBLIC ResourceManager
    * \note it is assumed that `prepare_command_mode_switch` is called just before this method
    * with the same input arguments.
    * \param[in] start_interfaces vector of string identifiers for the command interfaces starting.
-   * \param[in] stop_interfaces vector of string identifiers for the command interfacs stopping.
+   * \param[in] stop_interfaces vector of string identifiers for the command interfaces stopping.
    * \return true if switch is performed, false if a component rejects switching.
    */
   bool perform_command_mode_switch(

diff --git a/hardware_interface/include/hardware_interface/system_interface.hpp b/hardware_interface/include/hardware_interface/system_interface.hpp
@@ -132,7 +132,7 @@ class SystemInterface : public rclcpp_lifecycle::node_interfaces::LifecycleNodeI
    * \note All starting and stopping interface keys are passed to all components, so the function
    * should return return_type::OK by default when given interface keys not relevant for this
    * component. \param[in] start_interfaces vector of string identifiers for the command interfaces
-   * starting. \param[in] stop_interfaces vector of string identifiers for the command interfacs
+   * starting. \param[in] stop_interfaces vector of string identifiers for the command interfaces
    * stopping. \return return_type::OK if the new command interface combination can be prepared, or
    * if the interface key is not relevant to this system. Returns return_type::ERROR otherwise.
    */
@@ -151,7 +151,7 @@ class SystemInterface : public rclcpp_lifecycle::node_interfaces::LifecycleNodeI
    * \note All starting and stopping interface keys are passed to all components, so the function
    * should return return_type::OK by default when given interface keys not relevant for this
    * component. \param[in] start_interfaces vector of string identifiers for the command interfaces
-   * starting. \param[in] stop_interfaces vector of string identifiers for the command interfacs
+   * starting. \param[in] stop_interfaces vector of string identifiers for the command interfaces
    * stopping. \return return_type::OK if the new command interface combination can be switched to,
    * or if the interface key is not relevant to this system. Returns return_type::ERROR otherwise.
    */

diff --git a/joint_limits/include/joint_limits/joint_limits.hpp b/joint_limits/include/joint_limits/joint_limits.hpp
@@ -122,11 +122,14 @@ struct SoftJointLimits
   {
     std::stringstream ss_output;
 
-    ss_output << "  soft position limits: " << "[" << min_position << ", " << max_position << "]\n";
+    ss_output << "  soft position limits: "
+              << "[" << min_position << ", " << max_position << "]\n";
 
-    ss_output << "  k-position: " << "[" << k_position << "]\n";
+    ss_output << "  k-position: "
+              << "[" << k_position << "]\n";
 
-    ss_output << "  k-velocity: " << "[" << k_velocity << "]\n";
+    ss_output << "  k-velocity: "
+              << "[" << k_velocity << "]\n";
 
     return ss_output.str();
   }