Addressing review comments.

ros-controls · Jan 12, 2024 · cebd45e · cebd45e
1 parent 983dc47
commit cebd45e
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/hardware_interface/src/lexical_casts.cpp b/hardware_interface/src/lexical_casts.cpp
@@ -29,7 +29,7 @@ std::optional<double> stod(const std::string & s)
   stream >> result;
   if (stream.fail() || !stream.eof())
   {
-    throw std::invalid_argument("Failed converting string to real number");
+    return std::nullopt;
   }
   return result;
 #else
@@ -40,9 +40,7 @@ std::optional<double> stod(const std::string & s)
   {
     return result_value;
   }
-
   return std::nullopt;
-  ;
 #endif
 }
 }  // namespace impl