-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable setting of initial state in HW compoments #1046
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1046 +/- ##
==========================================
- Coverage 34.61% 32.34% -2.28%
==========================================
Files 52 93 +41
Lines 2981 9833 +6852
Branches 1855 6628 +4773
==========================================
+ Hits 1032 3180 +2148
- Misses 310 778 +468
- Partials 1639 5875 +4236
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THe only comment is regarding duplicating vs reworking the tests. Let's duplicate while the functionality is still there (we had issues with this before)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds fine for me now
(cherry picked from commit cf4448d) # Conflicts: # controller_manager/src/controller_manager.cpp # hardware_interface/include/hardware_interface/resource_manager.hpp # hardware_interface/src/resource_manager.cpp
) (cherry picked from commit cf4448d) --------- Co-authored-by: Dr. Denis <[email protected]> Co-authored-by: Bence Magyar <[email protected]> Co-authored-by: Christoph Froehlich <[email protected]>
This is the cleaned verison proposed in:
ros-controls/ros2_control_demos#277
Solves first part of #1045