Sort controllers while configuring instead of while activating (backport #1107)

[mergify]

This is an automatic backport of pull request #1107 done by Mergify.
Cherry-pick of 863f161 has failed:

On branch mergify/bp/humble/pr-1107
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 863f161.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   controller_manager/test/test_chainable_controller/test_chainable_controller.cpp
	modified:   controller_manager/test/test_controller/test_controller.cpp
	modified:   controller_manager/test/test_controller_manager.cpp
	modified:   controller_manager/test/test_load_controller.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   controller_manager/src/controller_manager.cpp
	both modified:   controller_manager/test/test_controller_manager_srvs.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

---

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

• @Mergifyio refresh will re-evaluate the rules
• @Mergifyio rebase will rebase this PR on its base branch
• @Mergifyio update will merge the base branch into this PR
• @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

• look at your merge queues
• generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

[saikishor]

Hello @bmagyar,

It seems like the initial controller sorting changes are not backported to Humble. What shall we do?

[bmagyar]

We could discuss if you want it... Perhaps the best way is a manual backport in that case, cherry picking the two merged PRs on top of humble

…

On Sat, 4 Nov 2023, 19:19 Sai Kishor Kothakota, ***@***.***> wrote: Hello @bmagyar <https://github.com/bmagyar>, It seems like the initial controller sorting changes are not backported to Humble. What shall we do? — Reply to this email directly, view it on GitHub <#1156 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA24PYNQCZQIB5JDAE4LCN3YC2INVAVCNFSM6AAAAAA65TR2IOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJTGUZTENJVGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[saikishor]

We could discuss if you want it... Perhaps the best way is a manual backport in that case, cherry picking the two merged PRs on top of humble

Hello @bmagyar,

I've opened a PR cherry-picking the 2 merged PRs as you mentioned.

Thank you!

[bmagyar]

No, thank you!