Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 695: Changing 'namespace_' variables to 'node_namespace' to make it more explicit #1239

Merged
merged 8 commits into from
Jan 8, 2024

Conversation

bailaC
Copy link
Contributor

@bailaC bailaC commented Dec 20, 2023

Correcting the namespace to node_namespace. #695

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (64c9e2a) 47.89% compared to head (6bb2353) 47.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1239   +/-   ##
=======================================
  Coverage   47.89%   47.89%           
=======================================
  Files          41       41           
  Lines        3451     3451           
  Branches     1876     1876           
=======================================
  Hits         1653     1653           
  Misses        444      444           
  Partials     1354     1354           
Flag Coverage Δ
unittests 47.89% <33.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...controller_interface/controller_interface_base.hpp 33.33% <ø> (ø)
.../include/controller_manager/controller_manager.hpp 18.18% <ø> (ø)
...roller_interface/src/controller_interface_base.cpp 48.14% <0.00%> (ø)
controller_manager/src/controller_manager.cpp 39.22% <50.00%> (ø)

@bailaC bailaC changed the title Issue 695 Issue 695: Changing 'namespace_' variables to 'node_namespace' to make it more explicit Jan 5, 2024
@bailaC bailaC marked this pull request as ready for review January 5, 2024 13:10
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bmagyar bmagyar merged commit 672480d into ros-controls:master Jan 8, 2024
13 checks passed
@bailaC bailaC deleted the issue-695 branch January 8, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants