-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 695: Changing 'namespace_' variables to 'node_namespace' to make it more explicit #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1239 +/- ##
=======================================
Coverage 47.89% 47.89%
=======================================
Files 41 41
Lines 3451 3451
Branches 1876 1876
=======================================
Hits 1653 1653
Misses 444 444
Partials 1354 1354
Flags with carried forward coverage won't be shown. Click here to find out more.
|
11 tasks
destogl
reviewed
Jan 5, 2024
controller_interface/include/controller_interface/controller_interface_base.hpp
Outdated
Show resolved
Hide resolved
bailaC
changed the title
Issue 695
Issue 695: Changing 'namespace_' variables to 'node_namespace' to make it more explicit
Jan 5, 2024
github-actions
bot
requested review from
bmagyar,
DasRoteSkelett,
destogl,
livanov93,
peterdavidfagan,
progtologist and
VanshGehlot
January 5, 2024 13:10
bmagyar
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correcting the namespace to node_namespace. #695