Initialize the controller manager services after initializing resource manager on humble #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bmagyar,
destogl,
erickisos,
jaron-l,
livanov93,
mcbed and
progtologist
dyackzan
changed the title
bmagyar
previously approved these changes
Jan 8, 2024
destogl
previously approved these changes
Jan 8, 2024
|
@dyackzan we are happy with the changes but not with the results of the tests. Were tests running fine for you locally? |
|
@bmagyar I did see the tests failing locally for me as well. I just added a commit that gets them passing again |
destogl
approved these changes
Jan 12, 2024
destogl
force-pushed
the
init_srvs_after_resource_manager_init_humble
branch
from
381f7aa to
4133248
Compare
This was referenced Jan 16, 2024
This was referenced Jan 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Humble version of @saikishor's main branch PR to fix functionality to load robot_description from a topic: #1271