-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rqt controller manager #1273
Fix rqt controller manager #1273
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1273 +/- ##
=======================================
Coverage 47.89% 47.89%
=======================================
Files 41 41
Lines 3451 3451
Branches 1876 1876
=======================================
Hits 1653 1653
Misses 444 444
Partials 1354 1354
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great, thanks :)
* add service_timeout to the other service methods * catch RuntimeErrors when the service is no longer available (cherry picked from commit 2d82de8) # Conflicts: # controller_manager/controller_manager/controller_manager_services.py # rqt_controller_manager/rqt_controller_manager/controller_manager.py
* add service_timeout to the other service methods * catch RuntimeErrors when the service is no longer available (cherry picked from commit 2d82de8)
…s#1273) * add service_timeout to the other service methods * catch RuntimeErrors when the service is no longer available
Fixes #1223
Before:
Now, instead of raising an exception and closing, it will clear the window and then connects to the server when it is available again