Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the multiple definitions of lexical casts methods (backport #1281) #1282

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 9, 2024

This is an automatic backport of pull request #1281 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@bmagyar bmagyar merged commit dcfde3a into humble Jan 9, 2024
12 of 13 checks passed
@mergify mergify bot deleted the mergify/bp/humble/pr-1281 branch January 9, 2024 16:10
@saikishor
Copy link
Member

saikishor commented Jan 10, 2024

@bmagyar one question, the CI says the changes break ABI, do you think it's an issue for the Humble and Iron releases?.
Weirdly, the CI only reports the ABI breaking for Broken libraries: libfake_components libmock_components

Do you think it will be an issue?. If so, maybe we can templatize them somehow to avoid another cpp and breaking the ABI. What do you think ?

@christophfroehlich and myself discussed in DM, but we are not sure, so we want to ask experts like you 😅

@bmagyar
Copy link
Member

bmagyar commented Jan 10, 2024

It is a new cpp file that was added to hardware_interface.so, it is very likely to break ABI there first. The component parser is also in this spot. It should not cause issues for controllers.

I think the harm was already done and we should consider this a bugfix.

@christophfroehlich
Copy link
Contributor

This means that after this being synced every hardware component out there will possibly segfault without a recompile? But this was already the case with the original lexical_casts.hpp? btw we don't have an ABI CI workflow for rolling in ros2_control.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants