-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHEL-CI] Rename workflow and don't run on push #1326
Conversation
d30879a
to
a64075b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1326 +/- ##
=======================================
Coverage 48.02% 48.02%
=======================================
Files 41 41
Lines 3525 3525
Branches 1912 1912
=======================================
Hits 1693 1693
Misses 442 442
Partials 1390 1390
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. +1 for naming and breaking up the different steps.
(cherry picked from commit fd2cc4e) # Conflicts: # .github/workflows/humble-rhel-binary-build.yml # .github/workflows/iron-rhel-binary-build.yml # .github/workflows/rolling-rhel-binary-build.yml
(cherry picked from commit fd2cc4e)
(cherry picked from commit fd2cc4e) Co-authored-by: Christoph Fröhlich <[email protected]>
Applying changes suggested here #1310 (comment) and add verbose option to
colcon test-result