-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix spawner tests timeout on source builds (backport #1692) #1697
Conversation
(cherry picked from commit 079392b) # Conflicts: # controller_manager/test/test_spawner_unspawner.cpp
Cherry-pick of 079392b has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## humble #1697 +/- ##
===========================================
- Coverage 87.00% 62.31% -24.70%
===========================================
Files 97 105 +8
Lines 7505 11319 +3814
Branches 677 7933 +7256
===========================================
+ Hits 6530 7053 +523
- Misses 688 807 +119
- Partials 287 3459 +3172
Flags with carried forward coverage won't be shown. Click here to find out more.
|
As reported by @christophfroehlich in #1685, it seems that spawner tests are inconsistent and timing out after some time. I was able to reproduce it locally and upon checking it seems like the CM's internal mutexes are blcoking as there is no ControllerManagerRunner in some of these tests. Adding these should fix the above timeout issues. I've tested it locally and it seems to work
Fixes #1685
This is an automatic backport of pull request #1692 done by Mergify.