Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ros2controlcli] fix list_controllers when no controllers are loaded #1721

Merged
merged 1 commit into from
Aug 27, 2024
Merged

[ros2controlcli] fix list_controllers when no controllers are loaded #1721

merged 1 commit into from
Aug 27, 2024

Conversation

saikishor
Copy link
Member

Fixes: #1715

@saikishor saikishor mentioned this pull request Aug 27, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Aug 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.81%. Comparing base (9e57adf) to head (6273ed4).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1721   +/-   ##
=======================================
  Coverage   86.81%   86.81%           
=======================================
  Files         116      116           
  Lines       10692    10692           
  Branches      978      978           
=======================================
  Hits         9282     9282           
  Misses       1059     1059           
  Partials      351      351
Flag Coverage Δ
unittests 86.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

christophfroehlich
christophfroehlich approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@christophfroehlich christophfroehlich added backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. backport-iron labels Aug 27, 2024
@bmagyar bmagyar merged commit d200408 into ros-controls:master Aug 27, 2024
19 of 20 checks passed
@bmagyar bmagyar deleted the fix/list_controllers/cli/empty branch August 27, 2024 12:45
mergify bot pushed a commit that referenced this pull request Aug 27, 2024
@saikishor @mergify
[ros2controlcli] fix list_controllers when no controllers are loaded (#…
6c3200b 
…1721)

(cherry picked from commit d200408)
mergify bot pushed a commit that referenced this pull request Aug 27, 2024
@saikishor @mergify
[ros2controlcli] fix list_controllers when no controllers are loaded (#…
4558197 
…1721)

(cherry picked from commit d200408)
This was referenced Aug 27, 2024
Merged
Merged
bmagyar pushed a commit that referenced this pull request Aug 30, 2024
@mergify
[ros2controlcli] fix list_controllers when no controllers are loaded (#…
4659d58 
…1721) (#1722)
bmagyar pushed a commit that referenced this pull request Aug 30, 2024
@mergify
[ros2controlcli] fix list_controllers when no controllers are loaded (#…
62a609c 
…1721) (#1723)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmagyar bmagyar bmagyar approved these changes

@christophfroehlich christophfroehlich christophfroehlich approved these changes

Assignees
No one assigned
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ros2controlcli: list_controllers throws error if no controller is loaded
3 participants
@saikishor @christophfroehlich @bmagyar