Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic error in informing user about real-time in ros2_control_node #1726

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

mamueluth
Copy link
Member

The logic in informing user about rt capabilities had logic error. User was informed that rt scheduling is set up when in fact is not setup.

Copy link
Contributor

mergify bot commented Aug 28, 2024

@mamueluth, all pull requests must be targeted towards the master development branch.
Once merged into master, it is possible to backport to humble, but it must be in master
to have these changes reflected into new distributions.

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 62.29%. Comparing base (9eb64ad) to head (0e62a03).
Report is 1 commits behind head on humble.

Files Patch % Lines
controller_manager/src/ros2_control_node.cpp 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #1726      +/-   ##
==========================================
- Coverage   62.30%   62.29%   -0.01%     
==========================================
  Files         105      105              
  Lines       11314    11315       +1     
  Branches     7925     7929       +4     
==========================================
  Hits         7049     7049              
- Misses        806      807       +1     
  Partials     3459     3459              
Flag Coverage Δ
unittests 62.29% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
controller_manager/src/ros2_control_node.cpp 77.41% <0.00%> (-2.59%) ⬇️

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops ;) Thanks for fixing my merge fix.

@bmagyar bmagyar merged commit caa242f into ros-controls:humble Aug 28, 2024
11 of 12 checks passed
@christophfroehlich
Copy link
Contributor

@Mergifyio backport iron

Copy link
Contributor

mergify bot commented Aug 28, 2024

backport iron

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants