-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix logic error in informing user about real-time in ros2_control_node #1726
Fix logic error in informing user about real-time in ros2_control_node #1726
Conversation
@mamueluth, all pull requests must be targeted towards the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## humble #1726 +/- ##
==========================================
- Coverage 62.30% 62.29% -0.01%
==========================================
Files 105 105
Lines 11314 11315 +1
Branches 7925 7929 +4
==========================================
Hits 7049 7049
- Misses 806 807 +1
Partials 3459 3459
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops ;) Thanks for fixing my merge fix.
@Mergifyio backport iron |
✅ Backports have been created
|
The logic in informing user about rt capabilities had logic error. User was informed that rt scheduling is set up when in fact is not setup.