Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CM] Throw an exception when the components initially fail to be in the required state (backport #1729) #1777

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 7, 2024

We faced another bug during our testing when the HW component failed to configure at the beginning, the CM prints that the Resource Manager is successfully initialized and exposes it's internal services and the spawner calls are being processed on startup.

I believe, If the user's initial intent is supposed to be in a particular state, it is better to have failed when this is not the case rather than continue to expose services and then fail again. Usually, when the services are exposed, it is expected that HW components are successfully initialized.


This is an automatic backport of pull request #1729 done by Mergify.

…he required state (#1729)

(cherry picked from commit 1c7a5d1)

# Conflicts:
#	controller_manager/src/controller_manager.cpp
@mergify mergify bot added the conflicts label Oct 7, 2024
Copy link
Contributor Author

mergify bot commented Oct 7, 2024

Cherry-pick of 1c7a5d1 has failed:

On branch mergify/bp/humble/pr-1729
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 1c7a5d1.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   controller_manager/src/controller_manager.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 62.25%. Comparing base (c04a16f) to head (57d0ebd).
Report is 30 commits behind head on humble.

Files with missing lines Patch % Lines
controller_manager/src/controller_manager.cpp 40.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           humble    #1777       +/-   ##
===========================================
- Coverage   87.00%   62.25%   -24.75%     
===========================================
  Files          97      105        +8     
  Lines        7505    11285     +3780     
  Branches      677     7888     +7211     
===========================================
+ Hits         6530     7026      +496     
- Misses        688      814      +126     
- Partials      287     3445     +3158     
Flag Coverage Δ
unittests 62.25% <40.00%> (-24.75%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
controller_manager/src/controller_manager.cpp 66.30% <40.00%> (-5.57%) ⬇️

... and 69 files with indirect coverage changes

@bmagyar bmagyar merged commit 5bf0da5 into humble Oct 9, 2024
10 of 11 checks passed
@bmagyar bmagyar deleted the mergify/bp/humble/pr-1729 branch October 9, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants