Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transmissions] Make transmission interface work with new variants approach #1845

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

saikishor
Copy link
Member

@saikishor saikishor commented Nov 4, 2024

The new changes to the handles, that the data exists inside the Handle itself will create problems with the old transmission_interface API and it is kinda dysfunctional with the new approach. This PR aims to solve the issue by migrating the transmission part to the new API and making it functional with the latest shared pointers approach.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 16 lines in your changes missing coverage. Please review.

Project coverage is 87.64%. Comparing base (3d57fc8) to head (a79ef49).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ce/include/transmission_interface/transmission.hpp 0.00% 9 Missing ⚠️
...ude/transmission_interface/simple_transmission.hpp 72.72% 1 Missing and 2 partials ⚠️
...ansmission_interface/differential_transmission.hpp 92.59% 0 Missing and 2 partials ⚠️
...ission_interface/four_bar_linkage_transmission.hpp 90.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1845      +/-   ##
==========================================
- Coverage   87.83%   87.64%   -0.19%     
==========================================
  Files         122      122              
  Lines       12926    13081     +155     
  Branches     1153     1161       +8     
==========================================
+ Hits        11353    11465     +112     
- Misses       1148     1188      +40     
- Partials      425      428       +3     
Flag Coverage Δ
unittests 87.64% <96.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...erface/include/transmission_interface/accessor.hpp 83.33% <ø> (ø)
..._interface/test/differential_transmission_test.cpp 99.53% <100.00%> (+0.15%) ⬆️
...erface/test/four_bar_linkage_transmission_test.cpp 99.52% <100.00%> (+0.13%) ⬆️
...ission_interface/test/simple_transmission_test.cpp 100.00% <100.00%> (ø)
transmission_interface/test/utils_test.cpp 100.00% <100.00%> (ø)
...ansmission_interface/differential_transmission.hpp 70.68% <92.59%> (-9.12%) ⬇️
...ission_interface/four_bar_linkage_transmission.hpp 68.22% <90.00%> (-9.68%) ⬇️
...ude/transmission_interface/simple_transmission.hpp 69.09% <72.72%> (-5.42%) ⬇️
...ce/include/transmission_interface/transmission.hpp 9.09% <0.00%> (-90.91%) ⬇️

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant