Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo use thread_priority (backport #1844) #1847

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 4, 2024

Fixed typo with the logs with the thread priority usage. Use the user set parameter thread priority rather than default kSchedPriority. If user doesn't set the thread_priority it will be defaulted to the kSchedPriority.


This is an automatic backport of pull request #1844 done by Mergify.

(cherry picked from commit be0a339)

# Conflicts:
#	controller_manager/src/ros2_control_node.cpp
@mergify mergify bot added the conflicts label Nov 4, 2024
Copy link
Contributor Author

mergify bot commented Nov 4, 2024

Cherry-pick of be0a339 has failed:

On branch mergify/bp/humble/pr-1844
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit be0a339.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   controller_manager/src/ros2_control_node.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.48%. Comparing base (ac9f005) to head (23c699e).
Report is 1 commits behind head on humble.

Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #1847      +/-   ##
==========================================
- Coverage   62.51%   62.48%   -0.03%     
==========================================
  Files         108      108              
  Lines       12156    12156              
  Branches     8247     8247              
==========================================
- Hits         7599     7596       -3     
- Misses        879      881       +2     
- Partials     3678     3679       +1     
Flag Coverage Δ
unittests 62.48% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
controller_manager/src/ros2_control_node.cpp 80.00% <ø> (ø)

... and 1 file with indirect coverage changes

@saikishor saikishor enabled auto-merge (squash) November 4, 2024 16:49
@saikishor saikishor disabled auto-merge November 4, 2024 16:49
@bmagyar bmagyar merged commit 92871d8 into humble Nov 4, 2024
9 of 11 checks passed
@bmagyar bmagyar deleted the mergify/bp/humble/pr-1844 branch November 4, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants