Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ros2_control_node] Add option to set the CPU affinity #1852

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

saikishor
Copy link
Member

@saikishor saikishor commented Nov 4, 2024

This PR adds an option to the ros2_control_node to be able to set the CPU affinity to bind it to a specific CPU Core. By default, this is not enabled, unless it is specifically set

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.21%. Comparing base (e6e69c1) to head (fe793a9).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
controller_manager/src/ros2_control_node.cpp 20.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1852      +/-   ##
==========================================
- Coverage   88.26%   88.21%   -0.06%     
==========================================
  Files         121      121              
  Lines       12303    12309       +6     
  Branches     1093     1095       +2     
==========================================
- Hits        10859    10858       -1     
- Misses       1051     1056       +5     
- Partials      393      395       +2     
Flag Coverage Δ
unittests 88.21% <20.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
controller_manager/src/ros2_control_node.cpp 80.95% <20.00%> (-8.24%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent!

@bmagyar bmagyar merged commit 98f0795 into ros-controls:master Nov 5, 2024
16 of 22 checks passed
@bmagyar bmagyar added backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. backport-iron labels Nov 5, 2024
mergify bot pushed a commit that referenced this pull request Nov 5, 2024
(cherry picked from commit 98f0795)

# Conflicts:
#	doc/release_notes.rst
@saikishor saikishor deleted the set/cpu_affinity branch November 5, 2024 10:09
mergify bot pushed a commit that referenced this pull request Nov 5, 2024
(cherry picked from commit 98f0795)

# Conflicts:
#	doc/release_notes.rst
saikishor added a commit to pal-robotics-forks/ros2_control that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants