Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ros2_control_node] Handle simulation environment clocks (backport #1810) #1862

Merged
merged 5 commits into from
Nov 8, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 7, 2024

As there are many ongoing issues that people are trying to use the ros2_control_node for the simulation environments and as it is not working, I wanted to see if this solution is something that we are interesting to go with or we simple reject the possibility

Related to : #859


This is an automatic backport of pull request #1810 done by Mergify.

(cherry picked from commit d714e8b)

# Conflicts:
#	controller_manager/src/ros2_control_node.cpp
#	doc/release_notes.rst
@mergify mergify bot added the conflicts label Nov 7, 2024
Copy link
Contributor Author

mergify bot commented Nov 7, 2024

Cherry-pick of d714e8b has failed:

On branch mergify/bp/humble/pr-1810
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit d714e8b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   controller_manager/src/ros2_control_node.cpp
	both modified:   doc/release_notes.rst

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 62.47%. Comparing base (a8696f4) to head (3cf9d72).
Report is 1 commits behind head on humble.

Files with missing lines Patch % Lines
controller_manager/src/ros2_control_node.cpp 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #1862      +/-   ##
==========================================
- Coverage   62.48%   62.47%   -0.01%     
==========================================
  Files         108      108              
  Lines       12166    12169       +3     
  Branches     8254     8257       +3     
==========================================
+ Hits         7602     7603       +1     
- Misses        883      884       +1     
- Partials     3681     3682       +1     
Flag Coverage Δ
unittests 62.47% <60.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
controller_manager/src/ros2_control_node.cpp 66.66% <60.00%> (-2.23%) ⬇️

@christophfroehlich christophfroehlich marked this pull request as draft November 8, 2024 08:25
@christophfroehlich christophfroehlich marked this pull request as ready for review November 8, 2024 13:28
@christophfroehlich christophfroehlich merged commit 246885f into humble Nov 8, 2024
8 of 13 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/humble/pr-1810 branch November 8, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants