Lock memory by default on a realtime system setup #1896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1896 +/- ##
=======================================
Coverage 87.85% 87.85%
=======================================
Files 121 121
Lines 12515 12516 +1
Branches 1124 1124
=======================================
+ Hits 10995 10996 +1
Misses 1108 1108
Partials 412 412
Flags with carried forward coverage won't be shown. Click here to find out more.
|
christophfroehlich
approved these changes
Nov 28, 2024
github-actions
bot
requested review from
aprotyas,
bmagyar,
christophfroehlich,
mcbed,
mhubii,
moriarty and
VX792
christophfroehlich
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Seems to be fair.
Is this aligned with the discussion in ros-controls/ros2_controllers#1389, @firesurfer?
This was referenced Dec 2, 2024
christophfroehlich
changed the title
bmagyar
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the logic of the lock memory to be dependent on a real-time kernel system or not