Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add clang job, setup concurrency, use rt_tools humble branch #1910

Merged
merged 16 commits into from
Dec 8, 2024

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Dec 3, 2024

  • This adds a semi-binary job using clang. I fixed all what clang was complaining about.
  • use humble branch of realtime_tools for humble CI

Closes #611

Additionally, I added the concurrency settings which now automatically cancel running workflows if anything is pushed to PRs.
https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/control-the-concurrency-of-workflows-and-jobs

@christophfroehlich christophfroehlich added the backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. label Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.75%. Comparing base (0ef99fe) to head (61dd1e3).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
controller_manager/src/ros2_control_node.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1910   +/-   ##
=======================================
  Coverage   87.75%   87.75%           
=======================================
  Files         122      122           
  Lines       12940    12940           
  Branches     1155     1155           
=======================================
  Hits        11355    11355           
  Misses       1159     1159           
  Partials      426      426           
Flag Coverage Δ
unittests 87.75% <93.75%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nclude/semantic_components/force_torque_sensor.hpp 100.00% <100.00%> (ø)
...roller_interface/src/controller_interface_base.cpp 82.47% <100.00%> (ø)
hardware_interface/src/component_parser.cpp 94.82% <100.00%> (ø)
...e_interface/src/mock_components/generic_system.cpp 83.96% <100.00%> (ø)
...dware_interface/test/test_component_interfaces.cpp 97.63% <100.00%> (ø)
hardware_interface/test/test_macros.cpp 100.00% <100.00%> (ø)
controller_manager/src/ros2_control_node.cpp 66.66% <0.00%> (ø)

@christophfroehlich christophfroehlich changed the title [CI] Add clang job [CI] Add clang job and setup concurrency Dec 4, 2024
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM

I noticed that we don't cancel jobs of pre-commit and docs. Anyway, they are pretty fast.

I'm also stumbled that clang doesn't like auto

@christophfroehlich
Copy link
Contributor Author

In general LGTM

I noticed that we don't cancel jobs of pre-commit and docs. Anyway, they are pretty fast.

they are cancelled! the other setups are the following: they are only cancelled in PRs, but not if it is pushed to the respective branches

I'm also stumbled that clang doesn't like auto

auto is not the problem, but std::distance etc return an integer.

saikishor
saikishor previously approved these changes Dec 4, 2024
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/humble-check-docs.yml Show resolved Hide resolved
@christophfroehlich christophfroehlich changed the title [CI] Add clang job and setup concurrency [CI] Add clang job, setup concurrency, use rt_tools humble branch Dec 8, 2024
@christophfroehlich christophfroehlich merged commit 6e896bf into master Dec 8, 2024
20 of 22 checks passed
@christophfroehlich christophfroehlich deleted the ci/clang branch December 8, 2024 21:39
mergify bot pushed a commit that referenced this pull request Dec 8, 2024
)

(cherry picked from commit 6e896bf)

# Conflicts:
#	.github/workflows/rolling-rhel-binary-build.yml
#	controller_interface/src/controller_interface_base.cpp
#	controller_manager/src/ros2_control_node.cpp
#	hardware_interface/src/component_parser.cpp
#	hardware_interface/src/mock_components/generic_system.cpp
#	hardware_interface/test/test_component_interfaces.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add clang CI step to master branch
2 participants