-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add clang job, setup concurrency, use rt_tools humble branch #1910
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1910 +/- ##
=======================================
Coverage 87.75% 87.75%
=======================================
Files 122 122
Lines 12940 12940
Branches 1155 1155
=======================================
Hits 11355 11355
Misses 1159 1159
Partials 426 426
Flags with carried forward coverage won't be shown. Click here to find out more.
|
773dc72
to
6ef14ac
Compare
227646e
to
e3284b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general LGTM
I noticed that we don't cancel jobs of pre-commit and docs. Anyway, they are pretty fast.
I'm also stumbled that clang doesn't like auto
they are cancelled! the other setups are the following: they are only cancelled in PRs, but not if it is pushed to the respective branches
auto is not the problem, but std::distance etc return an integer. |
This reverts commit 08ef135.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
) (cherry picked from commit 6e896bf) # Conflicts: # .github/workflows/rolling-rhel-binary-build.yml # controller_interface/src/controller_interface_base.cpp # controller_manager/src/ros2_control_node.cpp # hardware_interface/src/component_parser.cpp # hardware_interface/src/mock_components/generic_system.cpp # hardware_interface/test/test_component_interfaces.cpp
Closes #611
Additionally, I added the concurrency settings which now automatically cancel running workflows if anything is pushed to PRs.
https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/control-the-concurrency-of-workflows-and-jobs