Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Add downstream builds #1929

Merged
merged 9 commits into from
Dec 16, 2024
Merged

[CI] Add downstream builds #1929

merged 9 commits into from
Dec 16, 2024

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Dec 10, 2024 •
edited
Loading

  • run them only in PRs
  • build+test downstream ros-controls packages
  • build-only some downstream 3rd party packages. any more we should add?

@christophfroehlich christophfroehlich added the backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. label Dec 10, 2024
@saikishor saikishor mentioned this pull request Dec 10, 2024
Merged
@christophfroehlich
Copy link
Contributor Author

I submitted a PR to fix the failing tests to PickNikRobotics/topic_based_ros2_control#30

@saikishor
Copy link
Member

I submitted a PR to fix the failing tests to PickNikRobotics/topic_based_ros2_control#30

@christophfroehlich Should we wait until this is merged?

@christophfroehlich
Copy link
Contributor Author

I submitted a PR to fix the failing tests to PickNikRobotics/topic_based_ros2_control#30

@christophfroehlich Should we wait until this is merged?

fixed now

fmauch
fmauch approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitively a plus that we know early when something breaks :-)

@christophfroehlich christophfroehlich merged commit 10caa58 into master Dec 16, 2024
7 checks passed
@christophfroehlich christophfroehlich deleted the ci/downstream branch December 16, 2024 20:49
mergify bot pushed a commit that referenced this pull request Dec 16, 2024
@christophfroehlich @mergify
[CI] Add downstream builds (#1929)
13ffbb5 
(cherry picked from commit 10caa58)
@mergify mergify bot mentioned this pull request Dec 16, 2024
Merged
christophfroehlich pushed a commit that referenced this pull request Dec 16, 2024
@mergify
[CI] Add downstream builds (#1929) (#1946)
f5196ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmauch fmauch fmauch approved these changes

@aprotyas aprotyas Awaiting requested review from aprotyas

@ARK3r ARK3r Awaiting requested review from ARK3r

@arne48 arne48 Awaiting requested review from arne48

@bmagyar bmagyar Awaiting requested review from bmagyar

@olivier-stasse olivier-stasse Awaiting requested review from olivier-stasse

@saikishor saikishor Awaiting requested review from saikishor

Assignees
No one assigned
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christophfroehlich @saikishor @fmauch