fix: suppress unnecessary warnings in clock received validation

[TakashiSato]

This PR aims to fix clock received validation to suppress unnecessary warning logs.

Previously, the code was displaying warning logs when checking clock received status regardless of the validation timing. This could lead to excessive warning logs in normal operation scenarios.

Changes:

• Add explicit condition to check !get_clock()->received() before displaying warning log
• Keep the same warning message for when an actual clock sync issue occurs

This change helps reduce noise in logs by only reporting warnings when there's a genuine clock synchronization issue.

[saikishor]

You are right about this condition. Thanks for fixing it

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.72%. Comparing base (c37b9d9) to head (ba1c16b).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
controller_manager/src/controller_manager.cpp	0.00%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1935      +/-   ##
==========================================
- Coverage   87.73%   87.72%   -0.01%     
==========================================
  Files         122      122              
  Lines       12978    12979       +1     
  Branches     1156     1158       +2     
==========================================
  Hits        11386    11386              
- Misses       1164     1165       +1     
  Partials      428      428              

Flag	Coverage Δ
unittests	87.72% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
controller_manager/src/controller_manager.cpp	76.31% <0.00%> (-0.06%)	⬇️

[christophfroehlich]

Thanks for the fix!