Reuse spawner service clients #1947
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
anfemosa,
bmagyar,
christophfroehlich,
fmauch,
harderthan,
mamueluth and
rosterloh
bijoua29
force-pushed
the
spawner_single_client_per_service
branch
from
b4b45b0 to
b1036b7
Compare
saikishor
requested changes
Dec 16, 2024
Suggestions? |
I've an approach. I'm testing now. I'll open a PR if it works fine |
|
Closing this PR as #1949 is a better approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to reduce the overhead and DDS discovery issues associated with starting multiple controllers with the spawner. See #1934 for some background.
In this PR, we save off the service client in spawner for reuse for subsequent controllers so we're not creating a new service client for each controller. This change improves the performance and reduces the failures when starting multiple controllers at a time.
There may be a better way to do this so please comment.
Also, this PR conflicts with #1944 and may not require that PR anymore.