Make get_name() return a const reference #1952
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
aprotyas,
bmagyar,
christophfroehlich,
DasRoteSkelett,
fmauch,
LukasMacha97 and
qiayuanl
christophfroehlich
previously approved these changes
Dec 17, 2024
hardware_interface/include/hardware_interface/loaned_command_interface.hpp
Outdated
Show resolved
Hide resolved
hardware_interface/include/hardware_interface/loaned_state_interface.hpp
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1952 +/- ##
=======================================
Coverage 87.73% 87.74%
=======================================
Files 122 122
Lines 13010 13010
Branches 1165 1165
=======================================
+ Hits 11414 11415 +1
Misses 1165 1165
+ Partials 431 430 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
TakashiSato
dismissed stale reviews from christophfroehlich and saikishor
via
57bde07
|
@christophfroehlich |
saikishor
approved these changes
Dec 18, 2024
christophfroehlich
approved these changes
Dec 18, 2024
christophfroehlich
merged commit e7d2fcc
into
ros-controls:master
22 of 25 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a simple update: get_name() now returns const std::string& instead of std::string. This avoids unnecessary copies and improves efficiency.