Move test_utils module from demos repo #1955
Open
+225
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophfroehlich
force-pushed
the
add/test_utils
branch
from
c5c21ff to
2a8f8aa
Compare
christophfroehlich
changed the title
github-actions
bot
requested review from
destogl,
erickisos,
Maverobot,
mcbed,
rosterloh,
saikishor and
VX792
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1955 +/- ##
==========================================
+ Coverage 87.74% 88.38% +0.64%
==========================================
Files 122 120 -2
Lines 13019 12950 -69
Branches 1166 1156 -10
==========================================
+ Hits 11423 11446 +23
+ Misses 1165 1063 -102
- Partials 431 441 +10
Flags with carried forward coverage won't be shown. Click here to find out more. |
fmauch
reviewed
Dec 18, 2024
| namespace_api = "/" | ||
|
|
||
| while time.time() - start < 10.0 and not all(found.values()): | ||
| node_names_namespaces = node.get_node_names_and_namespaces() |
There was a problem hiding this comment.
Wasn't that the functionality that was causing trouble for us in the spawner when waiting for the controller manager?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As integration testing gets more popular I propose to release the
test_utilsfrom the ros2_control_demos repository.I added it to the controller_manager package to be able to use it in the test for the ros2_control_node.